Allon Mureinik has posted comments on this change.
Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Very minor issues.
Also, I'd consider separating ConfigurationValues cleanup and its test from the
rest of the patch - it can be self contained, and this patch is getting a bit
big.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
Line 22: private static List<String> getVersionsList() {
Line 23: List<String> versions = new ArrayList<String>();
Line 24: versions.add(Config.DefaultConfigurationVersion);
Line 25: for (Version version : Version.ALL) {
Line 26: versions.add(version.toString());
Why not just use versions.addAll(Version.ALL)?
Line 27: }
Line 28: return versions;
Line 29: }
Line 30:
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java
Line 33: break;
Line 34: }
Line 35: }
Line 36:
Line 37: assertFalse(missingKey);
Please add a message here.
Line 38: }
--
To view, visit http://gerrit.ovirt.org/8563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
