Roy Golan has posted comments on this change.
Change subject: engine: Integrate smartcard support
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 140: }
Line 141:
Line 142: @Override
Line 143: protected void readGeneralData(XmlNode content) {
Line 144: // General Vm
should have called super here.
Line 145: XmlNode node = content.SelectSingleNode("Name");
Line 146: if (node != null) {
Line 147: _vmTemplate.setname(node.InnerText);
Line 148: name = _vmTemplate.getname();
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 139: }
Line 140:
Line 141: @Override
Line 142: protected void readGeneralData(XmlNode content) {
Line 143: // General Vm
should have called super here
Line 144: XmlNode node = content.SelectSingleNode("Name");
Line 145: if (node != null) {
Line 146: _vm.getStaticData().setvm_name(node.InnerText);
Line 147: name = _vm.getStaticData().getvm_name();
--
To view, visit http://gerrit.ovirt.org/8484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa874d6316c4040253231a7a301a17d8b69eb4b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
