Omer Frenkel has posted comments on this change. Change subject: engine: Integrate smartcard support ......................................................................
Patch Set 10: Looks good to me, but someone else must approve +1 for backend side, important note for future patches: please separate big changes to smaller patch-sets, in general, code-refactoring (as done in the ovf code here) should always be separated, in this case, you could also split adding the new field to db and entities from the ui. -- To view, visit http://gerrit.ovirt.org/8484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaa874d6316c4040253231a7a301a17d8b69eb4b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
