Ramesh N has posted comments on this change.

Change subject: engine,webadmin : geo-rep status detail
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/32100/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java:

Line 30: currentSession.getSessionDetails()
when it will be null?. can the null check on the line no 15 will handle this?.

May be you can get all the sessionss as in line 24 and process them and finally 
call currentSession.setSessionDetails(currentSessionDetails);


-- 
To view, visit https://gerrit.ovirt.org/32100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to