anmolbabu has posted comments on this change. Change subject: engine,webadmin : geo-rep status detail ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/32100/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java: Line 30: currentSession.getSessionDetails() > when it will be null?. can the null check on the line no 15 will handle thi Basically, session and session details are obtained from 2 different commands. For syncing sessions we use session list command that gives all sessions part in a given cluster. But session details command gives session details for a particular session. So, I thought it would be safer to have a null check in place just to avoid situations like for some reason session list command gave us the expected data and then for sesison detail command something went wrong like engine lost connection to nodes or something unexpected like that. Regarding setting after all data is available, I'll incorporate it and update the patch set. -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
