Martin Betak has posted comments on this change. Change subject: webadmin: fix class cast exception in edit vm ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41887/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 187: getModel().getBehavior() > I believe this parameter is C# relict and not necessary. It can be null. Agreed, please don't use the `target` parameter of AsyncQuery constructor. Pass null or better yet use the AsyncQuery(callback) constructor. Line 193: existingVmModelBehavior > can be replaced by yes since we can access the outer class from the callback you can use ExistingVmModelBehavior.this.updateNumOfSockets() or just call `updateNumOfSockets()` directly. Please prefer this style to manual unboxing of `target` model in new code. -- To view, visit https://gerrit.ovirt.org/41887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0453e97b2789568b36793d12f34381c98933bd6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
