Omer Frenkel has posted comments on this change. Change subject: webadmin: fix class cast exception in edit vm ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/41887/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 183: getModel().getTotalCPUCores().getEntityChangedEvent().removeListener(getModel()); Line 184: getModel().getCoresPerSocket().getSelectedItemChangedEvent().removeListener(getModel()); Line 185: getModel().getNumOfSockets().getSelectedItemChangedEvent().removeListener(getModel()); Line 186: Line 187: AsyncDataProvider.getInstance().getHostById(new AsyncQuery(getModel().getBehavior(), new INewAsyncCallback() { > Agreed, please don't use the `target` parameter of AsyncQuery constructor. Done Line 188: @Override Line 189: public void onSuccess(Object model, Object returnValue) { Line 190: ExistingVmModelBehavior existingVmModelBehavior = (ExistingVmModelBehavior) model; Line 191: runningOnHost = (VDS) returnValue; Line 186: Line 187: AsyncDataProvider.getInstance().getHostById(new AsyncQuery(getModel().getBehavior(), new INewAsyncCallback() { Line 188: @Override Line 189: public void onSuccess(Object model, Object returnValue) { Line 190: ExistingVmModelBehavior existingVmModelBehavior = (ExistingVmModelBehavior) model; > also not necessary Done Line 191: runningOnHost = (VDS) returnValue; Line 192: hostCpu = calculateHostCpus(); Line 193: existingVmModelBehavior.updateNumOfSockets(); Line 194: } Line 189: public void onSuccess(Object model, Object returnValue) { Line 190: ExistingVmModelBehavior existingVmModelBehavior = (ExistingVmModelBehavior) model; Line 191: runningOnHost = (VDS) returnValue; Line 192: hostCpu = calculateHostCpus(); Line 193: existingVmModelBehavior.updateNumOfSockets(); > yes since we can access the outer class from the callback you can use Exist Done Line 194: } Line 195: }), vm.getRunOnVds()); Line 196: } Line 197: -- To view, visit https://gerrit.ovirt.org/41887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0453e97b2789568b36793d12f34381c98933bd6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
