Sharad Mishra has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 25: import org.ovirt.engine.core.bll.quota.QuotaConsumptionParameter;
Line 26: import org.ovirt.engine.core.bll.quota.QuotaVdsConsumptionParameter;
Line 27: import org.ovirt.engine.core.bll.quota.QuotaStorageDependent;
Line 28: import org.ovirt.engine.core.bll.quota.QuotaVdsDependent;
Line 29: import org.ovirt.engine.core.bll.quota.QuotaConsumptionParameters;
Class names QuotaConsumptionParameter and QuotaConsumptionParameters differ by
's' at the end. They can cause confusion. Can we rename
QuotaConsumtionParameters to something like QuotaConsumptionGlobalParameter?
Line 30: import
org.ovirt.engine.core.bll.quota.QuotaStorageConsumptionParameter;
Line 31: import org.ovirt.engine.core.bll.quota.Quotable;
Line 32: import org.ovirt.engine.core.bll.session.SessionDataContainer;
Line 33: import org.ovirt.engine.core.bll.tasks.AsyncTaskUtils;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaStorageDependent.java
Line 15: * Override this method in order to set the storage consumption
parameters for the quota check.
Line 16: * This method is called by CommandBase during the canDoAction
check in order to make sure the
Line 17: * command has sufficient quota resources in order to run.
Line 18: *
Line 19: * return null if the command does consume any storage resources.
shouldn't it be "return null if command doesn't consume ..."?
Line 20: *
Line 21: * @return - list of storage consumption parameters. null if no
consumption.
Line 22: */
Line 23: public List<QuotaStorageConsumptionParameter>
getQuotaStorageConsumptionParameters();
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 270: }
Line 271: }
Line 272:
Line 273: private VdcActionType(int value) {
Line 274: this(value, (ActionGroup) null); // null casting is a must in
order to identify the constructor we are calling
Why not call this(value, null, true, QuotaDependency.BOTH);
Line 275: }
Line 276:
Line 277: private VdcActionType(int value , QuotaDependency
quotaDependency) {
Line 278: this(value, null, quotaDependency);
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
