Michael Kublin has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 595:
Line 596: switch (this.getActionType().getQuotaDependency()) {
Line 597: case NONE:
Line 598: return true;
Line 599: case STORAGE:
consumptionParameters = getQuotaStorageConsumptionParameters()
will work fine.
Line 600: consumptionParameters.addAll(((QuotaStorageDependent)
this).getQuotaStorageConsumptionParameters());
Line 601: break;
Line 602: case VDS:
Line 603: consumptionParameters.addAll(((QuotaVdsDependent)
this).getQuotaVdsConsumptionParameters());
Line 606: consumptionParameters.addAll(((QuotaStorageDependent)
this).getQuotaStorageConsumptionParameters());
Line 607: consumptionParameters.addAll(((QuotaVdsDependent)
this).getQuotaVdsConsumptionParameters());
Line 608: break;
Line 609: }
Line 610:
I don't understand that code. All code from 611 till 622 is useless.
Line 611: QuotaConsumptionParametersWrapper
quotaConsumptionParametersWrapper;
Line 612: if (getStoragePool() != null) {
Line 613: quotaConsumptionParametersWrapper = new
QuotaConsumptionParametersWrapper(
Line 614: this.getStoragePool(),
this.getReturnValue().getCanDoActionMessages(), this);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java
Line 1: package org.ovirt.engine.core.bll.quota;
Line 2:
Line 3: import java.io.Serializable;
Line 4:
In java RuntimeException is Serializable.
Line 5: public class InvalidQuotaParametersException extends RuntimeException
implements Serializable {
Line 6: private static final long serialVersionUID = -1759699263394287888L;
Line 7:
Line 8: public InvalidQuotaParametersException() {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java
Line 36:
Line 37: public void setQuotaAction(QuotaAction quotaAction) {
Line 38: this.quotaAction = quotaAction;
Line 39: }
Line 40:
Really override of clone? What next a new method for toString(), hashCode()
etc..
Line 41: public abstract QuotaConsumptionParameter clone();
Line 42:
Line 43: public enum QuotaAction {
Line 44: CONSUME, RELEASE
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
Line 13: private List<QuotaConsumptionParameter> parameters;
Line 14:
Line 15: private storage_pool storage_pool;
Line 16: private ArrayList<String> canDoActionMessages;
Line 17: private AuditLogableBase auditLogable;
auditLogable is not used, why it was passed
Line 18:
Line 19: public QuotaConsumptionParametersWrapper(storage_pool storage_pool,
Line 20: ArrayList<String>
canDoActionMessages,
Line 21: AuditLogableBase
auditLogable) {
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
