Moti Asayag has posted comments on this change. Change subject: webadmin: Adding external status to UI ......................................................................
Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/40999/22/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/EntityAdditionalStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/EntityAdditionalStatusColumn.java: Line 29: } Line 30: Line 31: protected SafeHtml getImageSafeHtml(ImageResource imageResource) { Line 32: return SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(imageResource) Line 33: .getHTML()); please merge lines. Line 34: } Line 35: Line 36: protected SafeHtml getEntityValue(S s) { Line 37: return null; Line 40: protected SafeHtml getEntityTooltip(S object) { Line 41: return null; Line 42: } Line 43: Line 44: protected Object getEntityObject(S object) { the return type should be S, then you can avoid casting when this method is called. Line 45: return null; Line 46: } Line 47: Line 48: @Override -- To view, visit https://gerrit.ovirt.org/40999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e7066176e70ec94f543aa1120bb355acad9b0a Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
