Alona Kaplan has posted comments on this change. Change subject: webadmin: Adding external status to UI ......................................................................
Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/40999/15/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java: Line 16: import java.util.LinkedHashMap; Line 17: import java.util.List; Line 18: import java.util.Map; Line 19: Line 20: public class HostAdditionalStatusColumn<S> extends AbstractSafeHtmlColumn<S> { > It is not working with VDS, only with Generics , can show you that.... I changed it to 'public class HostAdditionalStatusColumn extends EntityAdditionalStatusColumn<VDS>' and it works fine. Line 21: Line 22: private final static ApplicationConstants constants = AssetProvider.getConstants(); Line 23: private final static ApplicationResources resources = AssetProvider.getResources(); Line 24: Line 56: } Line 57: else { Line 58: return null; Line 59: } Line 60: Map<SafeHtml, String> imagesToText = new LinkedHashMap<>(); > methods vary in implementation and I don't think that the above will add cl I don't agree. The structure of both of the methods is similar. If you will have bug in one of them, probably you will have the same bug in the other one. Line 61: Line 62: if (host.isUpdateAvailable()) { Line 63: imagesToText.put(getImageSafeHtml(resources.updateAvailableImage()), constants.updateAvailable()); Line 64: } -- To view, visit https://gerrit.ovirt.org/40999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e7066176e70ec94f543aa1120bb355acad9b0a Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
