Muli Salem has posted comments on this change.
Change subject: core: Adding getVdsInterfaceById
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java
Line 120: * @param id
Line 121: * the VdsNetworkInterface Id
Line 122: * @return the VdsNetworkInterfaces
Line 123: */
Line 124: VdsNetworkInterface get(Guid id);
Since we are in the VdsInterface context, get is sufficient.
The class itself needs to be changed to VdsNetworkInterfaceDAO.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java
Line 284: */
Line 285: @Test
Line 286: public void testGet() {
Line 287: VdsNetworkInterface result =
dao.get(existingVdsInterface.getId());
Line 288: assertEquals(existingVdsInterface, result);
Done
Line 289: }
Line 290:
Line 291: static private void
assertCorrectGetManagedInterfaceForVdsResult(VdsNetworkInterface result) {
Line 292: assertNotNull(result);
....................................................
Commit Message
Line 5: CommitDate: 2012-10-25 10:47:46 +0200
Line 6:
Line 7: core: Adding getVdsInterfaceById
Line 8:
Line 9: This patch adds the above stored procedure.
Done
Line 10:
Line 11: Change-Id: Ib993da030c145e25ec6b6b3f3d607dbd3d3774f1
--
To view, visit http://gerrit.ovirt.org/8708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib993da030c145e25ec6b6b3f3d607dbd3d3774f1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
