Moti Asayag has posted comments on this change. Change subject: core: Adding getVdsInterfaceById ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/dbscripts/network_sp.sql Line 344: Line 345: Create or replace FUNCTION GetVdsInterfaceById(v_vds_interface_id UUID) RETURNS SETOF vds_interface_view Line 346: AS $procedure$ Line 347: BEGIN Line 348: RETURN QUERY SELECT DISTINCT * the DISTINCT should be removed. We're searching by ID, therefore the expected result should contain a single entry only. There is also a primary key to enforce uniqueness by id. Line 349: FROM vds_interface_view Line 350: WHERE id = v_vds_interface_id; Line 351: END; $procedure$ Line 352: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/8708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib993da030c145e25ec6b6b3f3d607dbd3d3774f1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
