Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 23: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java
Line 22: if (brick.getQualifiedName().equals(qualifiedBrickName)) {
Line 23: return brick;
Line 24: }
Line 25: }
Line 26: // It is possible that the brick is not found, in cases where
user has added more bricks to the volume directly
This comment is not relevant in this context, so can be removed.
Line 27: // using gluster CLI (and this change has not been synced yet
by the GlusterManager).
Line 28: return null;
Line 29: }
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
