Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 22: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java
Line 34: }
Line 35: }
Line 36: }
Line 37:
Line 38: private void copyBrickDetails(BrickDetails fromBrick, BrickDetails
toBrick) {
On closer observation, it looks like this method is not about copying data from
'fromBrick' to 'toBrick', but some sort of 'merging' of data is happening here.
If so, the method name (possibly argument names also) definitely needs to
change to something that indicates what exactly is happening. Also, please add
method level javadoc explaining the logic (if method name + body doesn't make
it obvious)
Line 39: BrickProperties brickProperties =
fromBrick.getBrickProperties();
Line 40: brickProperties.setPid(toBrick.getBrickProperties().getPid());
Line 41:
brickProperties.setPort(toBrick.getBrickProperties().getPort());
Line 42:
brickProperties.setStatus(toBrick.getBrickProperties().getStatus());
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
