Michael Kublin has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 636: + ". Storage pool is not available for quota
calculation. ");
Line 637: return false;
Line 638: }
Line 639:
Line 640: QuotaConsumptionParametersWrapper
quotaConsumptionParametersWrapper = new QuotaConsumptionParametersWrapper(this,
no need to pass getReturnValue().getCanDoActionMessages()
Line 641: getReturnValue().getCanDoActionMessages());
Line 642:
quotaConsumptionParametersWrapper.setParameters(getQuotaConsumptionParameters());
Line 643:
Line 644: return true;
//quotaConsumptionParametersWrapper.getParameters().isEmpty() ||
getQuotaManager().consume(quotaConsumptionParametersWrapper);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
Line 8: public class QuotaConsumptionParametersWrapper {
Line 9:
Line 10: private List<QuotaConsumptionParameter> parameters;
Line 11:
Line 12: private AuditLogableBase auditLogable;
you don't need these variable it passed inside auditLogable.
My opinion that you don't need that class at all
Line 13: private List<String> canDoActionMessages;
Line 14:
Line 15: public QuotaConsumptionParametersWrapper(AuditLogableBase
auditLogable, List<String> canDoActionMessages) {
Line 16: this.auditLogable = auditLogable;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 310: public static VdcActionType forValue(int value) {
Line 311: return mappings.get(value);
Line 312: }
Line 313:
Line 314: public QuotaDependency getQuotaDependency() {
remove this
Line 315: return this.quotaDependency;
Line 316: }
Line 317:
Line 318: /**
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
