Liron Aravot has posted comments on this change.
Change subject: core: prevent clone VM while disk is locked
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 272: addCanDoActionMessage(String.format("$SnapshotName %1$s",
getSnapshotName()));
Line 273:
Line 274: return false;
Line 275: }
Line 276:
getSourceVmFromDb() can return null and cause NPE in
ImagesHandler.checkImagesLocked()
Line 277: if (!ImagesHandler.checkImagesLocked(getSourceVmFromDb(),
getReturnValue().getCanDoActionMessages())) {
Line 278: return false;
Line 279: }
Line 280:
--
To view, visit http://gerrit.ovirt.org/9031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9899744859475b2d27ca858c21279fb439768f9b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
