Allon Mureinik has posted comments on this change.
Change subject: core: prevent clone VM while disk is locked
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 364: }
Line 365:
Line 366: @Override
Line 367: protected Map<String, String> getExclusiveLocks() {
Line 368: if (getSourceVmFromDb() == null) {
Is there an extra newline here, or just a gerrit foobar?
Line 369: return null;
Line 370: }
Line 371:
Line 372: return
Collections.singletonMap(getSourceVmFromDb().getId().toString(),
LockingGroup.VM.name());
--
To view, visit http://gerrit.ovirt.org/9031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9899744859475b2d27ca858c21279fb439768f9b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
