Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 122: if (cache == null) {
Line 123: log.warn("ENGINE_CACHE environment not found using
tmpdir");
Line 124: cache = System.getProperty("java.io.tmpdir");
Line 125: }
Line 126: File bootstrapPackage = new File(cache, Config.<String>
GetValue(ConfigValues.BootstrapPackageName)) ;
In fact what you need to check here is if the directory exists, not the package:
File bootstrapDirectory = New File(Config.<String>
GetValue(CofigValues.BootstrapPackageDirectory));
File bootstrapPackage = ....;
if (bootstrapDirectory.exists()) {
s_bootrapPackage = new CachedTar(bootstrapPackage, bootstrapDirectory);
}
else {
log.warn(...);
}
Line 127: if (bootstrapPackage.exists()) {
Line 128: s_bootstrapPackage = new CachedTar(
Line 129: bootstrapPackage,
Line 130: new File(Config.<String>
GetValue(ConfigValues.BootstrapPackageDirectory)));
--
To view, visit http://gerrit.ovirt.org/9086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d96ecf67ed18e0bd28853c002e763b3978620dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
