Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
......................................................................
Patch Set 4: (2 inline comments)
Some minor comments inside.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 62:
Line 63: protected final VdsInstallerSSH _wrapper = new VdsInstallerSSH();
Line 64: private final OpenSslCAWrapper _caWrapper = new OpenSslCAWrapper();
Line 65: protected String _serverName;
Line 66: private final boolean _rebootAfterInstallation;
This change to final doesn't belong in this patch. If the variable was not
marked as final by the original author it probably means that he intended to be
able to modify it after first assignment.
Either remove this from this patch or ask the original author for review.
Line 67: private final String _rootPassword;
Line 68: private final String remoteFwRulesFilePath;
Line 69: private final String _remoteSSHKey;
Line 70: private boolean isAddOvirtFlow = false;
Line 126: File bootstrapDirectory = new File(cache, Config.<String>
GetValue(ConfigValues.BootstrapPackageDirectory)) ;
Line 127: if (bootstrapDirectory.exists()) {
Line 128: s_bootstrapPackage = new CachedTar(
Line 129: new File(cache, Config.<String>
GetValue(ConfigValues.BootstrapPackageName)),
Line 130: bootstrapDirectory);
Try to keep the spacing as it was before:
s_boostrapPackage = CachedTar(
new File(...),
bootstrapDirectory
);
Line 131: }
Line 132: else {
Line 133: log.warn("The directory containing bootstrap scripts
\"" + bootstrapDirectory.getAbsolutePath() + "\" doesn't exist. Is the package
containing those files installed?");
Line 134: }
--
To view, visit http://gerrit.ovirt.org/9086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d96ecf67ed18e0bd28853c002e763b3978620dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
