Yair Zaslavsky has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values ......................................................................
Patch Set 2: I would prefer that you didn't submit this Hi Ravi, The change at AddVmCommand bothers me. I understand the logic behind the erasure of the lines. However, how can we guarantee that in the future we will not need to support for example two versions in which one of them has MaxNumOfVmCpus equals to 64, and the other is MaxNumOfVmCpus with 128? -- To view, visit http://gerrit.ovirt.org/9091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36928233e7022a1daa5fabb89535b91fe78bf186 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
