Allon Mureinik has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(6 inline comments)
+300 on the idea, but the patch is incomplete, and leaves a bunch of leftovers
and dead-code points - see inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 310
Line 311
Line 312
Line 313
Line 314
Note that you removed all the usages of VmCommand.validateNumberOfNics, so this
function itself can also be removed.
Line 311
Line 312
Line 313
Line 314
Line 315
This patch indeed removes all usages of this message.
Ravi, please note this should be removed both in VdcBllMessages.java, and in
all the relevant .properties files.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
Line 190: .RunVdsCommand(VDSCommandType.FormatStorageDomain,
Line 191: new
FormatStorageDomainVDSCommandParameters(vds.getId(),
dom.getId())).getSucceeded();
Line 192: }
Line 193:
Line 194: protected boolean removeStorage(storage_domains dom, VDS vds) {
Indeed.
Also, RemoveVGVDSCommand can be removed, and the entire call-stack it intiates.
Line 195: return true;
Line 196: }
Line 197:
Line 198: @Override
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java
Line 61
Line 62
Line 63
Line 64
Line 65
After this patch, this error message will no longer be used anywhere - it
should be removed.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 96
Line 97
Line 98
Line 99
Line 100
This is the only occurrence of
VdcBllMessages.CUSTOM_VM_PROPERTIES_INVALID_VALUES_NOT_ALLOWED_IN_CURRENT_CLUSTER
- you should also remove this message itself.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 54: VmPriorityMaxValue(ConfigAuthType.User),
Line 55: StorageDomainNameSizeLimit(ConfigAuthType.User),
Line 56: StoragePoolNameSizeLimit(ConfigAuthType.User),
Line 57: SANWipeAfterDelete(ConfigAuthType.User),
Line 58: AuthenticationMethod(ConfigAuthType.User),
Same as Omer's comment on ConfigValues - if there are any values here that
reference the values in ConfigValues, they too should be removed.
Line 59: UserDefinedVMProperties(ConfigAuthType.User),
Line 60: PredefinedVMProperties(ConfigAuthType.User),
Line 61: SupportCustomProperties(ConfigAuthType.User),
Line 62: VdsFenceOptionTypes,
--
To view, visit http://gerrit.ovirt.org/9131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
