Shireesh Anjal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment in-line.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java
Line 228: /**
Line 229: * @return Valid parameters for the command.
Line 230: */
Line 231: private GlusterServerParameters createParameters() {
Line 232: GlusterServerParameters parameters = new
GlusterServerParameters(Guid.NewGuid(), false);
I don't see a need for this method. You could directly use "new
GlusterServerParameters(Guid.NewGuid(), false)" inside setUp()
I know this method already existed and you have just modified it, but I would
still recommend you to fix this.
Line 233: return parameters;
Line 234: }
--
To view, visit http://gerrit.ovirt.org/8894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b8fa947cd6a6ece79ecfe00041f54e31e9e7ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
