Shireesh Anjal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
......................................................................
Patch Set 1: No score
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 27: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 28:
Line 29: @NonTransactiveCommandAttribute
Line 30: @LockIdNameAttribute
Line 31: public class RemoveVdsCommand<T extends GlusterServerParameters>
extends VdsCommand<T> {
On some more thought, I don't think calling this "GlusterServerParameters" is a
good idea since this command itself is generic and not gluster specific. So the
parameters class should be called something like RemoveVdsParameters.
Another option is to introduce the "forceAction" boolean on VdsActionParameters
itself, with default value as false.
I request Omer to comment on this.
Line 32:
Line 33: private AuditLogType errorType =
AuditLogType.USER_FAILED_REMOVE_VDS;
Line 34: private VDS upServer;
Line 35:
--
To view, visit http://gerrit.ovirt.org/8894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b8fa947cd6a6ece79ecfe00041f54e31e9e7ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
