Allon Mureinik has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 83: ) {
Line 84: try {
Line 85: T parameters = getParameters();
Line 86: _vdsInstaller = new OVirtUpgrader(getVds(),
parameters.getoVirtIsoFile());
Line 87:
Backend.getInstance().getResourceManager().RunVdsCommand(
iirc, you can just use runVdsCommand()
Line 88: VDSCommandType.SetVdsStatus,
Line 89: new SetVdsStatusVDSCommandParameters(
Line 90: getVdsId(),
Line 91: VDSStatus.Installing
Line 97: getVds().getId(),
Line 98: getVds().getvds_name()
Line 99: );
Line 100: if (!_vdsInstaller.Install()) {
Line 101: throw new Exception("Upgrade failed");
how about throwing a BllException?
Line 102: }
Line 103: log.infoFormat(
Line 104: "After upgrade {0}, host {0}, {1}: success",
Line 105: Thread.currentThread().getName(),
--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
