Yair Zaslavsky has posted comments on this change.

Change subject: bootstrap: split the logic of ovirt-node upgrade out
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 101:                     throw new Exception("Upgrade failed");
Line 102:                 }
Line 103:                 log.infoFormat(
Line 104:                     "After upgrade {0}, host {0}, {1}: success",
Line 105:                     Thread.currentThread().getName(),
I am pretty sure the thread name is already provided at engine-log due to the 
log4j configuration we use.
Line 106:                     getVds().getId(),
Line 107:                     getVds().getvds_name()
Line 108:                 );
Line 109:                 setSucceeded(true);


--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to