ofri masad has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 15: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 649: throw new InvalidQuotaParametersException("Command: " +
this.getClass().getName()
Line 650: + ". No Quota parameters available.");
Line 651: }
Line 652:
Line 653: boolean result =
true;//getQuotaManager().consume(quotaConsumptionParametersWrapper);
Since getQuotaManager().consume() is not yet implemented in this patch i cannot
call it. the comment was left to indicate the connection point to next patch.
Line 654: setQuotaWasChanged(result);
Line 655: return result;
Line 656: }
Line 657:
Line 1663: private int getExecutionIndex() {
Line 1664: return getParameters().getExecutionIndex();
Line 1665: }
Line 1666:
Line 1667: public boolean isQuotaWasChanged() {
Done
Line 1668: return quotaWasChanged;
Line 1669: }
Line 1670:
Line 1671: public void setQuotaWasChanged(boolean quotaWasChanged) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaStorageConsumptionParameter.java
Line 5:
Line 6: public class QuotaStorageConsumptionParameter extends
QuotaConsumptionParameter {
Line 7:
Line 8: private Guid storageDomainId;
Line 9: private Double requestedStorageGB;
Answered Liron. this will be changed to double.
Line 10:
Line 11: public QuotaStorageConsumptionParameter(Guid quotaGuid,
Line 12: Quota quota,
Line 13: QuotaAction quotaAction,
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
