Allon Mureinik has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(2 inline comments)
minor issues, see inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 641: + ". Storage pool is not available for quota
calculation. ");
Line 642: }
Line 643:
Line 644: QuotaConsumptionParametersWrapper
quotaConsumptionParametersWrapper = new QuotaConsumptionParametersWrapper(this,
Line 645: getReturnValue().getCanDoActionMessages());
I'd fold this up to the previous line
Line 646:
quotaConsumptionParametersWrapper.setParameters(getQuotaConsumptionParameters());
Line 647:
Line 648: if (quotaConsumptionParametersWrapper.getParameters() ==
null) {
Line 649: throw new InvalidQuotaParametersException("Command: " +
this.getClass().getName()
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java
Line 17: public Guid getQuotaGuid() {
Line 18: return quotaGuid;
Line 19: }
Line 20:
Line 21: public void setQuotaGuid(Guid quotaGuid) {
Didn't we talk about removing this?
Line 22: this.quotaGuid = quotaGuid;
Line 23: }
Line 24:
Line 25: public Quota getQuota() {
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
