Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] Remove global lock on SPM calls from engine side
......................................................................
Patch Set 1: (3 inline comments)
First comments, need to think more...
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 480: setmIrsPort(vds.getport());
Line 481: setmCurrentIrsHost(vds.gethost_name());
Line 482: }
Line 483:
Line 484: public boolean failover(Guid currentCommandSpmId, Set<Guid>
mTriedVdssList) {
I thought mTriedVddsList is a field that is initialized upon object creation.
Any reason why we need to pass it as argument?
Line 485: synchronized (syncObj) {
Line 486: mTriedVdssList.add(currentCommandSpmId);
Line 487: if (currentCommandSpmId.equals(mCurrentVdsId)) {
Line 488: if (getHasVdssForSpmSelection(mCurrentVdsId,
mTriedVdssList)) {
Line 1553: }
Line 1554:
Line 1555: protected IIrsServer getIrsProxy() {
Line 1556: IIrsServer irsProxy;
Line 1557: synchronized (getCurrentIrsProxyData().syncObj) {
Isn't the lock too string here? can it be RWLock ?
are there state-altering operations during getIrsProxy and getId ?
Line 1558: irsProxy =
getCurrentIrsProxyData().getIrsProxy(mTriedVdssList);
Line 1559: if (irsProxy != null) {
Line 1560: currentCommandSpmId = irsProxy.getId();
Line 1561: } else {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
Line 10: public class IrsServerWrapper implements IIrsServer {
Line 11:
Line 12: private IrsServerConnector irsServer;
Line 13: private HttpClient httpClient;
Line 14: private Guid id;
What is this id stand for? Is it an ID per IrsServer? this is not so clear.
Line 15:
Line 16: public IrsServerWrapper(IrsServerConnector innerImplementor,
HttpClient httpClient, Guid id) {
Line 17: this.irsServer = innerImplementor;
Line 18: this.httpClient = httpClient;
--
To view, visit http://gerrit.ovirt.org/9298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
