Liron Aravot has posted comments on this change.

Change subject: core: Remove global lock on SPM calls from engine side
......................................................................


Patch Set 3: I would prefer that you didn't submit this

possible deadlock now - correct me if i'm wrong.

thread a -> execute irs command , error during execution -> failover() - > 
lock.writeLock().lock() - > synchronized (syncObj)
 
thread b- timer ->  _updatingTimer_Elapsed() -> synchronized (syncObj) -> 
ProceedStoragePoolStats() -> GetStoragePoolInfo ->  
getCurrentIrsProxyData().lock.readLock().lock()

--
To view, visit http://gerrit.ovirt.org/9298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to