Michael Kublin has posted comments on this change.
Change subject: core: Default disk aliases when reading OVFs
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
Line 23:
Line 24: /**
Line 25: * Assign disk aliases to all the disks if there were none
assigned.
Line 26: * This method assumes taht {@link #BuildDisk()} and {@link
#BuildVirtualSystem()} were already called.
Line 27: */
Why I need these method, why it is can be done inside BuildDisk()? It is
belongs to disk and whole disk should be parsed together.
Line 28: void FixDiskAliases();
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
Line 174: readGeneralData();
Line 175: }
Line 176:
Line 177: /** Fixes disk alias if they are missing */
Line 178: @Override
Why I need to fix these, why these can not be done when a disk created?
Why I need additional loop?
Line 179: public void FixDiskAliases() {
Line 180: for (int i = 0; i < _images.size(); ++i) {
Line 181: DiskImage disk = _images.get(i);
Line 182: if (StringUtils.isEmpty(disk.getDiskAlias())) {
--
To view, visit http://gerrit.ovirt.org/9308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38ad9c56f9b97e174807d3fcbe0b3e43355803ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
