Vered Volansky has posted comments on this change.
Change subject: core: Default disk aliases when reading OVFs
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
Line 22: void BuildVirtualSystem();
Line 23:
Line 24: /**
Line 25: * Assign disk aliases to all the disks if there were none
assigned.
Line 26: * This method assumes taht {@link #BuildDisk()} and {@link
#BuildVirtualSystem()} were already called.
s/taht/that
Line 27: */
Line 28: void FixDiskAliases();
....................................................
Commit Message
Line 15: In order to provide a good default, the same default as the upgrade
Line 16: script was used (VmName_DiskXXX, where XXX is a running number,
starting
Line 17: at 1).
Line 18: This default obviously requires both the VM's data and the disks' data
Line 19: to be read from the OVF. In order not to "rock the boat" too much, and
s/and/a
Line 20: new method was added to IOvfBuilder - FixDiskAliases().
Line 21:
Line 22: This patch includes:
Line 23: * The aforementioned API change to IOvfBuilder, its implementation and
Line 25: * A test case for OvfVmReader to test the new logic.
Line 26: * Sample OVF files for the test case, one with disk aliases and one
Line 27: without them.
Line 28: * A fixup to a bug in RemoveImageTest that generates alias-less disks
Line 29: which now is strictly illegal.
s/now is/is now
Line 30:
Line 31: Change-Id: I38ad9c56f9b97e174807d3fcbe0b3e43355803ee
Line 32: Bug-Url: https://bugzilla.redhat.com/872506
--
To view, visit http://gerrit.ovirt.org/9308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38ad9c56f9b97e174807d3fcbe0b3e43355803ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
