Liron Aravot has posted comments on this change.
Change subject: core: Extract disk alias generation methods
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/disks/DiskUtils.java
Line 44: }
Line 45: return diskAlias;
Line 46: }
Line 47:
Line 48: public static String getDefaultDiskAlias(String prefix, String
suffix) {
*two or more*, generally its the compiler can optimize the code to use
stringbuilder, but its not guaranteed...it's not that it'll be the end of the
world to not use it here, i just prefer to.
Line 49: return prefix + DISK + suffix;
Line 50: }
Line 51:
Line 52: public static boolean setDiskAlias(BaseDisk disk, VM vm) {
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
