Maor Lipchuk has posted comments on this change.
Change subject: core: Extract disk alias generation methods
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/disks/DiskUtils.java
Line 36: diskAlias);
Line 37: } else {
Line 38: diskAlias = disk.getDiskAlias();
Line 39: if (StringUtils.isEmpty(diskAlias)) {
Line 40: diskAlias = getDefaultDiskAlias(diskPrefix,
String.valueOf(count));
I disagree with removing the log, this log will be printed if the disk alias is
empty which is not that common - there for, no flood might ocour.
IMHO much logs as we can, might help us a lot solving future bugs.
Line 41: log.infoFormat("Disk alias retrieved from the client
is null or empty, the suggested default disk alias to be used is {0}",
Line 42: diskAlias);
Line 43: }
Line 44: }
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
