Yair Zaslavsky has posted comments on this change.
Change subject: core: WIP : OvfDataUpdater - removal calls to
updateVm/TemplateInSpm
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
Line 115:
Line 116:
VmHandler.LockVm(getParameters().getVmStaticData().getId());
Line 117: } else {
Line 118: // if no disks send update vm here
Line 119:
getVmDAO().incrementVmDbGeneration(getParameters().getVmStaticData().getId());
Missed it at previous review.
Question - why via getVmDao()? and not via VmStaticDao()?
Line 120: }
Line 121:
Line 122: return ret;
Line 123: }
--
To view, visit http://gerrit.ovirt.org/9340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedebceb9809dc0b11c0bbe8a2d4af63b0d848df1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
