Michael Kublin has posted comments on this change.
Change subject: core: WIP : OvfDataUpdater - removal calls to
updateVm/TemplateInSpm
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 150: @SuppressWarnings("unchecked")
Line 151: final List<VM> vmsInPool = (List<VM>)
Backend.getInstance()
Line 152: .runInternalQuery(VdcQueryType.Search,
p).getReturnValue();
Line 153:
Line 154: executeInNewTransaction(new
TransactionMethod<Object>() {
You can not write a query which will update all generations of vms of same
pool.
I will help you, it should be something like that:
UPDATE vm_static set ovf_generation = 0 where pool_id = ....;
Simple?
Line 155: @Override
Line 156: public Void runInTransaction() {
Line 157: for (VM vm : vmsInPool) {
Line 158:
getVmDAO().updateVmOvfGeneration(vm.getId(), 0);
--
To view, visit http://gerrit.ovirt.org/9340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedebceb9809dc0b11c0bbe8a2d4af63b0d848df1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
