Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade ......................................................................
Patch Set 10: > I have to say that I feel a bit offended when you say that I have to open my > mind. I consider myself open minded, and I think this has nothing to do with > that. I am very sorry, did not intend to offend in any way. I just have the same argument with any pure java developers out there, which I do not understand, except of following some paper written over 15 years ago. > Did you ask yourself if you are being open minded in this particular subject? > It looks to me that instead you want to force others to use what you like or > are used to. I tried to follow your approach as we discussed few months ago, and it has only disadvantages over *ANY* code convention. I truly tries. As I wrote there are advantages in having this kind of code convention. So after I finished opened my mind, and tried it out, I reached my initial conclusion, that in order to properly maintain and review a scoping convention should be applied. So now I am asking you to see the benefits in such convention. It does not mean we change the whole project over night, but understand the positive factors, and maybe start using it in new modules. BTW: The hostinstall package was already implemented in that convention. Thank you! -- To view, visit http://gerrit.ovirt.org/9174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
