Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
......................................................................
Patch Set 10:
Let's look at the following hank:
diff --git a/a.java b/a.java
index 0232fc2..a6b57eb 100644
--- a/a.java
+++ b/b.java
log("log");
+String name = o.name + ".tmp";
+log("name is " + name);
-description = o.name;
+description = name;
Now, what can you say about name variable? does it shadow class member and
cause some errors within method? What do we know about description? does it in
method scope so it does not change the object state and behavior, or it is a
class member and changing it may change next calls? Or it is class member and
static, meaning it will also change every object created from now on?
A simple code convention which does not alter any of the java convention (as
the same way you are entitled to add suffixes just as Impl and Internal, you
are entitled to add prefixes), helps in understanding the code and the
implications.
The java convention it-self is kept to the word, variable names, method names,
capitalization etc.
Arguing that one need to review the whole source in order to understand a hank
is not counter productive, as instead of improve the tools at hand we narrow
them.
I am sorry, but you did not add any argument of the benefit of not having a
convention at hand.
--
To view, visit http://gerrit.ovirt.org/9174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
