Eli Mesika has posted comments on this change.

Change subject: Adding system information to getCapabilities from host
......................................................................


Patch Set 1: Fails

(2 inline comments)

Also 2 questions here :

1) UI part is missing from this patch, where this information is displayed , I 
thought that you will have it in the UI when selecting a Host

2) Does those fields be exposed to the Search Engine ???

....................................................
File backend/manager/dbscripts/create_tables.sql
Line 432: CREATE TABLE vds_dynamic
Line 433: (
Line 434:    vds_id UUID NOT NULL,
Line 435:    status INTEGER NOT NULL,
Line 436:    host_manufacturer VARCHAR(40),
yes, you should , to see how 
cd to dbscripts/upgrade
grep -i fn_db_add_column *.sql

Please read 
http://wiki.ovirt.org/wiki/OVirt-DB-Issues/dbupgrade
Line 437:    host_product_name VARCHAR(40),
Line 438:    host_version VARCHAR(40),
Line 439:    host_serial_number VARCHAR(40),
Line 440:    host_uuid VARCHAR(40),


....................................................
File 
backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
Line 41:           'vds_group_id', 'vds_group_name', 'vds_group_description', 
'selection_algorithm',
Line 42:           'vds_id', 'vds_name', 'ip', 'vds_unique_id', 'host_name', 
'port', 'vds_strength',
Line 43:           'server_ssl_enabled', 'vds_type', 'pm_type', 'pm_user', 
'pm_password', 'pm_port',
Line 44:           'pm_options', 'pm_enabled', 'vds_spm_priority', 'hooks', 
'status', 'host_manufacturer',
Line 45:           'host_product_name', 'host_version', 'host_serial_number', 
'host_uuid', 'host_family', 'cpu_cores',
As those are new columns , please append them to the end
Line 46:           'cpu_model', 'cpu_speed_mh', 'if_total_speed', 
'kvm_enabled', 'physical_mem_mb',
Line 47:           'pending_vcpus_count', 'pending_vmem_size', 'mem_commited', 
'vm_active', 'vm_count',
Line 48:           'vm_migrating', 'vms_cores_count', 
'cpu_over_commit_time_stamp', 'hypervisor_type',
Line 49:           'net_config_dirty', 'high_utilization', 'low_utilization', 
'max_vds_memory_over_commit',


--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to