Eli Mesika has posted comments on this change. Change subject: Adding system information to getCapabilities from host ......................................................................
Patch Set 4: (3 inline comments) Also keep in mind that we already have a 03_01_1520 script , so , you will have to rename .................................................... File backend/manager/dbscripts/vds_sp.sql Line 141: v_host_version VARCHAR(40), Line 142: v_host_serial_number VARCHAR(40), Line 143: v_host_uuid VARCHAR(40), Line 144: v_host_family VARCHAR(40), Line 145: v_cpu_cores INTEGER , as those values added last , why pushing it at first and not appending last as it should be ? Line 146: v_cpu_model VARCHAR(255) , Line 147: v_cpu_speed_mh DECIMAL(18,0) , Line 148: v_if_total_speed VARCHAR(40) , Line 149: v_kvm_enabled BOOLEAN , Line 201: v_host_version VARCHAR(40), Line 202: v_host_serial_number VARCHAR(40), Line 203: v_host_uuid VARCHAR(40), Line 204: v_host_family VARCHAR(40), Line 205: v_cpu_cores INTEGER , same Line 206: v_cpu_model VARCHAR(255) , Line 207: v_cpu_speed_mh DECIMAL(18,0) , Line 208: v_if_total_speed VARCHAR(40) , Line 209: v_kvm_enabled BOOLEAN , Line 249: UPDATE vds_dynamic Line 250: SET host_manufacturer = v_host_manufacturer, host_product_name = v_host_product_name, Line 251: host_version = v_host_version, host_serial_number = v_host_serial_number, Line 252: host_uuid = v_host_uuid, host_family = v_host_family, cpu_cores = v_cpu_cores, Line 253: cpu_model = v_cpu_model,cpu_speed_mh = v_cpu_speed_mh, same Line 254: if_total_speed = v_if_total_speed,kvm_enabled = v_kvm_enabled, Line 255: mem_commited = v_mem_commited,physical_mem_mb = v_physical_mem_mb, Line 256: status = v_status,vm_active = v_vm_active,vm_count = v_vm_count, Line 257: vm_migrating = v_vm_migrating,reserved_mem = v_reserved_mem, -- To view, visit http://gerrit.ovirt.org/9337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
