Tal Nisan has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment, but aside for that it looks good, since it's a big patch I gave
+1 in order to let someone else review also, but basically it's a +2
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1: package org.ovirt.engine.ui.uicompat;
Line 2:
What's the use of removing the lines here?
Line 3: public interface Constants extends com.google.gwt.i18n.client.Constants
{
Line 4:
Line 5: @DefaultStringValue("OK")
Line 6: String ok();
--
To view, visit http://gerrit.ovirt.org/9365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I264952895c33454e925ca2c109dd019a61aab879
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
