Alona Kaplan has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
Line 166: public void Execute(final Object... parameters)
Line 167: {
Line 168: // Optimization: using deferred command to defer command
execution to a later
Line 169: // time (after the browser event loop returns) in order to
keep UI responsive
Line 170: Scheduler.get().scheduleDeferred(new ScheduledCommand() {
I think using scheduleDeferred on execute can cause a lot of bugs.
Events that run between the first part (Execute) and the second (doExecute) can
effect the state (e.g. selection) of the model the command should run on. It
can cause a bug when running the command (e.g. if the selection was changed,
executing the command on the wrong entity).
Line 171: @Override
Line 172: public void execute() {
Line 173: doExecute(parameters);
Line 174: }
--
To view, visit http://gerrit.ovirt.org/9365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I264952895c33454e925ca2c109dd019a61aab879
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
