Yair Zaslavsky has posted comments on this change. Change subject: engine: Integrate Atlassian Crowd Client as a new Authentication Domain ......................................................................
Patch Set 1: Justin - you should use the same change-id - What I do in such cases is - have your fixes , perform local commit on your local branch, perform a fixup (git rebase -i origin/master and then for the 2nd patch mark it as "f" or "fixup") - this will "meld" the 2nd patch into the first one, so the 1st commit message including change-id will be kept, and when you perform git push origin HEAD:refs/for/master , gerrit will recognize this is a 2nd round of review. -- To view, visit http://gerrit.ovirt.org/9324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae0df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Justin Hammond <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Justin Hammond <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
