Juan Hernandez has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
......................................................................
Patch Set 1: (2 inline comments)
In order to build an RPM you just have to type "make rpm" from the top level
source directory. That will generate a set of .rpm files in the "output"
directory. Then you can install them with "yum localinstall *.rpm". This only
works for Fedora 17 at the moment.
Take into account that once the RPMs are installed the crowd .jar files will
*not* be copied to /usr/share/ovirt-engine/engine.ear/lib directory. But for
your tests you can just manually copy them there. If it works fine we can then
see what needs to be modified in the RPM to package them.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/CrowdBrokerUtils.java
Line 51: public static boolean initCrowd() {
Line 52: /* if we have already init'd Crowd, then don't do it again */
Line 53: if (crowdok == false) {
Line 54: Properties m_CrowdConfig = new Properties();
Line 55: File f = new File("/etc/ovirt-engine/",
"crowd.properties");
If you find things that are using fixed paths please let me know, as it is
probably something to fix.
Line 56: try {
Line 57: m_CrowdConfig.load(new FileReader(f));
Line 58: } catch (Exception e) {
Line 59: log.warnFormat("Failed to load Crowd Configuration
from file {0}{1}: {2}",
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/CrowdSearchUserByQueryCommand.java
Line 11: }
Line 12:
Line 13: @Override
Line 14: protected void ExecuteQuery() {
Line 15: List<AdUser> userList = CrowdBrokerUtils.getAllUsers();
Ok, I just wanted to make sure that you are aware.
Line 16: setReturnValue(userList);
Line 17: setSucceeded(true);
Line 18: }
Line 19:
--
To view, visit http://gerrit.ovirt.org/9324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae0df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Justin Hammond <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Justin Hammond <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
