Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
......................................................................
Patch Set 12: (7 inline comments)
Thank you!
I am glad it all about format.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
Line 27: public void post(Severity severity, String text) {
Line 28: AuditLogType logType;
Line 29: AuditLogableBase logable = new AuditLogableBase(_vds.getId());
Line 30: logable.AddCustomValue("Message", text);
Line 31: switch (severity) {
OK, if that really bothers. violates[1].
[1] http://docs.oracle.com/javase/tutorial/java/nutsandbolts/switch.html
Line 32: case INFO:
Line 33: logType = AuditLogType.VDS_INSTALL_IN_PROGRESS;
Line 34: log.infoFormat("Installation {0}: {1}",
_vds.gethost_name(), text);
Line 35: break;
Line 92
Line 93
Line 94
Line 95
Line 96
This should be final I guess...
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
Line 27:
Line 28: private static final int BUFFER_SIZE = 10 * 1024;
Line 29: private static final int THREAD_JOIN_TIMEOUT = 20 * 1000;
Line 30:
Line 31: private static Log log = LogFactory.getLog(OVirtNodeUpgrade.class);
Right, done for VdsDeploy, not this.
Line 32:
Line 33: private SSHDialog.Control _control;
Line 34: private Thread _thread;
Line 35: private EngineSSHDialog _dialog;
Line 45: /**
Line 46: * Set vds object status.
Line 47: * @param status new status.
Line 48: *
Line 49: * For this simple task, no need to go via command mechanism.
Done
Line 50: */
Line 51: private void _setVdsStatus(VDSStatus status) {
Line 52: _vds.setstatus(status);
Line 53:
Line 116: */
Line 117: @Override
Line 118: public void finalize() {
Line 119: close();
Line 120: }
Will always use. Nothing changed, I don't accept your approach.
Line 121:
Line 122: /**
Line 123: * Free resources.
Line 124: */
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java
Line 59: */
Line 60: public void useDefaultKeyPair() throws KeyStoreException {
Line 61: String alias = Config.<String>GetValue(ConfigValues.CertAlias);
Line 62: String p12 = Config.<String>GetValue(ConfigValues.keystoreUrl);
Line 63: char[] password =
Config.<String>GetValue(ConfigValues.keystorePass).toCharArray();
Done
Line 64:
Line 65: KeyStore.PrivateKeyEntry entry;
Line 66: InputStream in = null;
Line 67: try {
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
Line 292: }
Line 293: else {
Line 294: stdinList = new
LinkedList<InputStream>(Arrays.asList(initial));
Line 295: }
Line 296: stdinList.add(pinStdin);
Because it make the code more complex in a place where efficiency is not
important.
Line 297:
Line 298: try {
Line 299: sink.setControl(
Line 300: new Control() {
--
To view, visit http://gerrit.ovirt.org/9174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
