Roy Golan has posted comments on this change. Change subject: core: validate max lun disk attachment ......................................................................
Patch Set 3: I wanted to prefix the canDo methods but I understand its clear at first glance. btw I'd like to see it as a convention in all the commands but its getting harder to do such stuff. my problem with "verifyXXX" is that it doesn't hint on any return value or side effect (filling canDo messages). I'm open to other suggestions. -- To view, visit http://gerrit.ovirt.org/9409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
