Maor Lipchuk has posted comments on this change.
Change subject: core: validate max lun disk attachment
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 146:
Line 147: return returnValue;
Line 148: }
Line 149:
Line 150: private boolean canAddSharableDisk() {
/s/sharable/shareable
Line 151: if (getParameters().getDiskInfo().isShareable()) {
Line 152: if (!Config.<Boolean>
GetValue(ConfigValues.ShareableDiskEnabled,
Line 153:
getStoragePool().getcompatibility_version().getValue())) {
Line 154:
addCanDoActionMessage(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL);
Line 151: if (getParameters().getDiskInfo().isShareable()) {
Line 152: if (!Config.<Boolean>
GetValue(ConfigValues.ShareableDiskEnabled,
Line 153:
getStoragePool().getcompatibility_version().getValue())) {
Line 154:
addCanDoActionMessage(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL);
Line 155: return false;
failCanDoAction?
Line 156: } else if
(!isVolumeFormatSupportedForShareable(((DiskImage)
getParameters().getDiskInfo()).getvolume_format())) {
Line 157:
addCanDoActionMessage(VdcBllMessages.SHAREABLE_DISK_IS_NOT_SUPPORTED_BY_VOLUME_FORMAT);
Line 158: return false;
Line 159: }
Line 154:
addCanDoActionMessage(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL);
Line 155: return false;
Line 156: } else if
(!isVolumeFormatSupportedForShareable(((DiskImage)
getParameters().getDiskInfo()).getvolume_format())) {
Line 157:
addCanDoActionMessage(VdcBllMessages.SHAREABLE_DISK_IS_NOT_SUPPORTED_BY_VOLUME_FORMAT);
Line 158: return false;
failCanDoAction?
Line 159: }
Line 160: }
Line 161: return true;
Line 162: }
Line 182:
Line 183: private boolean checkFreeSpace() {
Line 184: if (!hasFreeSpace(getStorageDomain())) {
Line 185:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW);
Line 186: return false;
failCanDoAction?
Line 187: }
Line 188: return true;
Line 189: }
Line 190:
--
To view, visit http://gerrit.ovirt.org/9409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
