Allon Mureinik has uploaded a new change for review. Change subject: core: ImportVm cleanup: fix modifiers ......................................................................
core: ImportVm cleanup: fix modifiers applied static and final modifier that were missing from the class' methods and members. Change-Id: Ia5c3d14c575e4045101a9345b09ce7d630e0933e Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/9613/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java index 09ecef4..1eb4335 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java @@ -501,7 +501,7 @@ setSucceeded(true); } - private boolean hasSnappableDisks(VM vm) { + private static boolean hasSnappableDisks(VM vm) { return !vm.getImages().isEmpty(); } @@ -815,7 +815,7 @@ } - private void logField(VmStatic vmStaticFromOvf, String fieldName, String fieldValue) { + private static void logField(VmStatic vmStaticFromOvf, String fieldName, String fieldValue) { String vmName = vmStaticFromOvf.getvm_name(); AuditLogableBase logable = new AuditLogableBase(); logable.AddCustomValue("FieldName", fieldName); @@ -955,8 +955,6 @@ return super.getAuditLogTypeValue(); } - private static Log log = LogFactory.getLog(ImportVmCommand.class); - @Override protected List<Class<?>> getValidationGroups() { if (getParameters().isImportAsNewEntity()) { @@ -1012,4 +1010,6 @@ } return list; } + + private static final Log log = LogFactory.getLog(ImportVmCommand.class); } -- To view, visit http://gerrit.ovirt.org/9613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5c3d14c575e4045101a9345b09ce7d630e0933e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
