Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: fix modifiers
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 500:
Line 501: setSucceeded(true);
Line 502: }
Line 503:
Line 504: private static boolean hasSnappableDisks(VM vm) {
Good point.
Will move it there, and probably extract to it's own patch, as it is not part
of "changing modifiers" in this patch.
Line 505: return !vm.getImages().isEmpty();
Line 506: }
Line 507:
Line 508: private void addVmToDb() {
Line 501: setSucceeded(true);
Line 502: }
Line 503:
Line 504: private static boolean hasSnappableDisks(VM vm) {
Line 505: return !vm.getImages().isEmpty();
The context is importing - we do not /export/ the sharable property, so it is
not imported.
But you are correct - this is a bad name.
Line 506: }
Line 507:
Line 508: private void addVmToDb() {
Line 509: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
--
To view, visit http://gerrit.ovirt.org/9613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c3d14c575e4045101a9345b09ce7d630e0933e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
