Ravi Nori has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 268: protected List<VM> getVmsFromExportDomain() {
Line 269: GetAllFromExportDomainQueryParameters p =
Line 270: new GetAllFromExportDomainQueryParameters
Line 271: (getParameters().getStoragePoolId(),
getParameters().getSourceDomainId());
Line 272: VdcQueryReturnValue qretVal =
getBackend().runInternalQuery(VdcQueryType.GetVmsFromExportDomain, p);
Should we consider changing variable name this to qRetVal?
Line 273:
Line 274: if (!qretVal.getSucceeded()) {
Line 275: return null;
Line 276: }
Line 358:
Line 359: return true;
Line 360: }
Line 361:
Line 362: /** Validate that there is no duplicate VM. */
Can you please reformat to standard style
/**
* comment
* @return
*/
Line 363: protected boolean validateNoDuplicateVm() {
Line 364: VmStatic duplicateVm = getVmStaticDAO().get(getVm().getId());
Line 365: if (duplicateVm != null) {
Line 366:
addCanDoActionMessage(VdcBllMessages.VM_CANNOT_IMPORT_VM_EXISTS);
--
To view, visit http://gerrit.ovirt.org/9626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d711cd8df8c0f8eccfe6b7838c16605829b2f6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
